New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#1134): Allow extending the weak label matrix with embeddings #1487
Conversation
Ok, I will merge this tour de France when the tests pass. A quick conclusion of this journey:
|
Well, it looks like we're finally getting this feature... As improvement points:
for record in wl.records():
record.embedding = ..... So, the
But it should be better to tackle them (if apply) in a different PR |
5aae674
to
a054acc
Compare
Codecov Report
@@ Coverage Diff @@
## master #1487 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 126 126
Lines 6232 6278 +46
=======================================
+ Hits 5953 5997 +44
- Misses 279 281 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I just talked about his comments with @frascuchon
We think it would be very helpful if one could materialize/load a
I think more tests with different datasets and rules would be necessary to find a reliable and practical (cheap) method ... would be a good project for a student :) |
a054acc
to
e48d5d8
Compare
…1487) * feat: add extend method + test * docs: add tutorial * improve extend_matrix docstring * fix: fix syntax error on notebook * fix: fix syntax error on notebook * fix: remove mix parameter on extend_matrix * fix: remove mix parameter on extend_matrix + type hints * fix: remove mix parameter on extend_matrix + type hints * chore: add faiss-cpu to dev dependencies * docs: final version of the tutorial * docs: small fix * test: add more tests Co-authored-by: ruanchaves <ruanchaves93@gmail.com> (cherry picked from commit 20ee14a)
…1487) * feat: add extend method + test * docs: add tutorial * improve extend_matrix docstring * fix: fix syntax error on notebook * fix: fix syntax error on notebook * fix: remove mix parameter on extend_matrix * fix: remove mix parameter on extend_matrix + type hints * fix: remove mix parameter on extend_matrix + type hints * chore: add faiss-cpu to dev dependencies * docs: final version of the tutorial * docs: small fix * test: add more tests Co-authored-by: ruanchaves <ruanchaves93@gmail.com> (cherry picked from commit 20ee14a)
Closes #1134 and #1309