Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prepare_for_training supports spacy #1635

Merged
merged 5 commits into from
Jul 22, 2022
Merged

Conversation

frascuchon
Copy link
Member

This PR brings the works started by @ignacioct in #1584 adding support to spaCy for the prepare_for_training method.

Refs #420 and #1584

@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #1635 (41559c0) into master (076ab06) will decrease coverage by 0.15%.
The diff coverage is 88.37%.

@@            Coverage Diff             @@
##           master    #1635      +/-   ##
==========================================
- Coverage   95.36%   95.20%   -0.16%     
==========================================
  Files         135      135              
  Lines        6444     6502      +58     
==========================================
+ Hits         6145     6190      +45     
- Misses        299      312      +13     
Flag Coverage Δ
pytest 95.20% <88.37%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/client/datasets.py 96.91% <88.37%> (-1.08%) ⬇️
...ubrix/labeling/text_classification/label_errors.py 86.74% <0.00%> (-3.62%) ⬇️
src/rubrix/listeners/listener.py 91.20% <0.00%> (-3.30%) ⬇️
src/rubrix/listeners/models.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c6121...41559c0. Read the comment docs.

@frascuchon frascuchon self-assigned this Jul 22, 2022
@frascuchon frascuchon added this to In progress in Release via automation Jul 22, 2022
@frascuchon frascuchon moved this from In progress to Pending Review in Release Jul 22, 2022
Copy link
Contributor

@dcfidalgo dcfidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Added a few inline suggestions.

src/rubrix/client/datasets.py Outdated Show resolved Hide resolved
src/rubrix/client/datasets.py Outdated Show resolved Hide resolved
src/rubrix/client/datasets.py Outdated Show resolved Hide resolved
src/rubrix/client/datasets.py Show resolved Hide resolved
src/rubrix/client/datasets.py Outdated Show resolved Hide resolved
frascuchon and others added 2 commits July 22, 2022 09:35
Co-authored-by: David Fidalgo <david@recogn.ai>
@frascuchon frascuchon merged commit 00f9197 into master Jul 22, 2022
Release automation moved this from Pending Review to Waiting Release Jul 22, 2022
@frascuchon frascuchon deleted the feat/spacy_docbin branch July 22, 2022 14:46
@frascuchon frascuchon removed this from Waiting Release in Release Aug 18, 2022
frascuchon added a commit that referenced this pull request Aug 18, 2022
frascuchon added a commit that referenced this pull request Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants