New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: refactor button component #1674
Merged
leiyre
merged 2 commits into
style/align_with_design_system
from
style/button_component
Aug 10, 2022
Merged
style: refactor button component #1674
leiyre
merged 2 commits into
style/align_with_design_system
from
style/button_component
Aug 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Style: Align App UI with the design system closes #1670 * style: Rename variables and clean unused code (#1673) see #1670 * style: refactor button component (#1674) * style: refactor button component see #1672 * replace class name * style: Refactor dropdown component (#1677) * style: Refactor selector (#1679) see #1672 This PR centralizes all application selectors (single and multiple) in a single component, also the filterable search in selector is centralized in a new component * style: Clean up old code and rename components see #1670 This PR cleans up the old code, does some refactoring and renames the components using kebab-case and changing the prefix "re-" to "base-" * style: Slider component (#1680) see #1672 This PR creates reusable slider nav (navigation between sentences in text2text) * style: Tooltip placeholder (#1681) see #1672 This PR enhances and centralizes the appearance of the tooltip * style: Update deep selector (#1682) see #1672 This PR changes the deprecated v-deep selector for the new one :deep() * style: Refactor score filter (#1683) see #1670 This PR does a refactoring of the score filter, avoiding duplicate code, it also normalizes the size variables. * style: Refactor metrics components (#1684) see #1670 This PR standardizes the metric classes, removing duplicate styles and simplifying the management of some future changes * style: New entity label component (#1685) see #1670 This PR creates a new entity label component to avoid duplication (sidebar and header) * style: Add new small border-radius variable (#1695) see #1670 * style: refactor entities selector (#1696) see #1670 This PR adds entity label component in entities selector, also includes kebab-case in some nuxt-link * rename core folder to base * fix checkbox margin * remove unused prop * decorator * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix copy text * force commit * update test snapshot Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Closes #1670
frascuchon
pushed a commit
that referenced
this pull request
Sep 27, 2022
* Style: Align App UI with the design system closes #1670 * style: Rename variables and clean unused code (#1673) see #1670 * style: refactor button component (#1674) * style: refactor button component see #1672 * replace class name * style: Refactor dropdown component (#1677) * style: Refactor selector (#1679) see #1672 This PR centralizes all application selectors (single and multiple) in a single component, also the filterable search in selector is centralized in a new component * style: Clean up old code and rename components see #1670 This PR cleans up the old code, does some refactoring and renames the components using kebab-case and changing the prefix "re-" to "base-" * style: Slider component (#1680) see #1672 This PR creates reusable slider nav (navigation between sentences in text2text) * style: Tooltip placeholder (#1681) see #1672 This PR enhances and centralizes the appearance of the tooltip * style: Update deep selector (#1682) see #1672 This PR changes the deprecated v-deep selector for the new one :deep() * style: Refactor score filter (#1683) see #1670 This PR does a refactoring of the score filter, avoiding duplicate code, it also normalizes the size variables. * style: Refactor metrics components (#1684) see #1670 This PR standardizes the metric classes, removing duplicate styles and simplifying the management of some future changes * style: New entity label component (#1685) see #1670 This PR creates a new entity label component to avoid duplication (sidebar and header) * style: Add new small border-radius variable (#1695) see #1670 * style: refactor entities selector (#1696) see #1670 This PR adds entity label component in entities selector, also includes kebab-case in some nuxt-link * rename core folder to base * fix checkbox margin * remove unused prop * decorator * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix copy text * force commit * update test snapshot Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Closes #1670 (cherry picked from commit 52bbceb)
frascuchon
pushed a commit
that referenced
this pull request
Sep 27, 2022
* Style: Align App UI with the design system closes #1670 * style: Rename variables and clean unused code (#1673) see #1670 * style: refactor button component (#1674) * style: refactor button component see #1672 * replace class name * style: Refactor dropdown component (#1677) * style: Refactor selector (#1679) see #1672 This PR centralizes all application selectors (single and multiple) in a single component, also the filterable search in selector is centralized in a new component * style: Clean up old code and rename components see #1670 This PR cleans up the old code, does some refactoring and renames the components using kebab-case and changing the prefix "re-" to "base-" * style: Slider component (#1680) see #1672 This PR creates reusable slider nav (navigation between sentences in text2text) * style: Tooltip placeholder (#1681) see #1672 This PR enhances and centralizes the appearance of the tooltip * style: Update deep selector (#1682) see #1672 This PR changes the deprecated v-deep selector for the new one :deep() * style: Refactor score filter (#1683) see #1670 This PR does a refactoring of the score filter, avoiding duplicate code, it also normalizes the size variables. * style: Refactor metrics components (#1684) see #1670 This PR standardizes the metric classes, removing duplicate styles and simplifying the management of some future changes * style: New entity label component (#1685) see #1670 This PR creates a new entity label component to avoid duplication (sidebar and header) * style: Add new small border-radius variable (#1695) see #1670 * style: refactor entities selector (#1696) see #1670 This PR adds entity label component in entities selector, also includes kebab-case in some nuxt-link * rename core folder to base * fix checkbox margin * remove unused prop * decorator * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix copy text * force commit * update test snapshot Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Closes #1670 (cherry picked from commit 52bbceb)
frascuchon
pushed a commit
that referenced
this pull request
Sep 27, 2022
* Style: Align App UI with the design system closes #1670 * style: Rename variables and clean unused code (#1673) see #1670 * style: refactor button component (#1674) * style: refactor button component see #1672 * replace class name * style: Refactor dropdown component (#1677) * style: Refactor selector (#1679) see #1672 This PR centralizes all application selectors (single and multiple) in a single component, also the filterable search in selector is centralized in a new component * style: Clean up old code and rename components see #1670 This PR cleans up the old code, does some refactoring and renames the components using kebab-case and changing the prefix "re-" to "base-" * style: Slider component (#1680) see #1672 This PR creates reusable slider nav (navigation between sentences in text2text) * style: Tooltip placeholder (#1681) see #1672 This PR enhances and centralizes the appearance of the tooltip * style: Update deep selector (#1682) see #1672 This PR changes the deprecated v-deep selector for the new one :deep() * style: Refactor score filter (#1683) see #1670 This PR does a refactoring of the score filter, avoiding duplicate code, it also normalizes the size variables. * style: Refactor metrics components (#1684) see #1670 This PR standardizes the metric classes, removing duplicate styles and simplifying the management of some future changes * style: New entity label component (#1685) see #1670 This PR creates a new entity label component to avoid duplication (sidebar and header) * style: Add new small border-radius variable (#1695) see #1670 * style: refactor entities selector (#1696) see #1670 This PR adds entity label component in entities selector, also includes kebab-case in some nuxt-link * rename core folder to base * fix checkbox margin * remove unused prop * decorator * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix copy text * force commit * update test snapshot Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Closes #1670 (cherry picked from commit 52bbceb)
frascuchon
pushed a commit
that referenced
this pull request
Sep 27, 2022
* Style: Align App UI with the design system closes #1670 * style: Rename variables and clean unused code (#1673) see #1670 * style: refactor button component (#1674) * style: refactor button component see #1672 * replace class name * style: Refactor dropdown component (#1677) * style: Refactor selector (#1679) see #1672 This PR centralizes all application selectors (single and multiple) in a single component, also the filterable search in selector is centralized in a new component * style: Clean up old code and rename components see #1670 This PR cleans up the old code, does some refactoring and renames the components using kebab-case and changing the prefix "re-" to "base-" * style: Slider component (#1680) see #1672 This PR creates reusable slider nav (navigation between sentences in text2text) * style: Tooltip placeholder (#1681) see #1672 This PR enhances and centralizes the appearance of the tooltip * style: Update deep selector (#1682) see #1672 This PR changes the deprecated v-deep selector for the new one :deep() * style: Refactor score filter (#1683) see #1670 This PR does a refactoring of the score filter, avoiding duplicate code, it also normalizes the size variables. * style: Refactor metrics components (#1684) see #1670 This PR standardizes the metric classes, removing duplicate styles and simplifying the management of some future changes * style: New entity label component (#1685) see #1670 This PR creates a new entity label component to avoid duplication (sidebar and header) * style: Add new small border-radius variable (#1695) see #1670 * style: refactor entities selector (#1696) see #1670 This PR adds entity label component in entities selector, also includes kebab-case in some nuxt-link * rename core folder to base * fix checkbox margin * remove unused prop * decorator * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix copy text * force commit * update test snapshot Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Closes #1670 (cherry picked from commit 52bbceb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1672