Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#1658): align agents for predictions annotations #1742

Merged
merged 2 commits into from
Oct 3, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Sep 30, 2022

This PR includes changes related to #1658 to align/normalize predictions/annotations keys with the agent fields:

  • For the prediction field, agents will be computed from the key
  • For the predictions field, agents will be set to None

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 94.97% // Head: 95.02% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (b30899f) compared to base (8588972).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           releases/0.x    #1742      +/-   ##
================================================
+ Coverage         94.97%   95.02%   +0.04%     
================================================
  Files               148      148              
  Lines              6812     6815       +3     
================================================
+ Hits               6470     6476       +6     
+ Misses              342      339       -3     
Flag Coverage Δ
pytest 95.02% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/daos/models/records.py 97.05% <100.00%> (+0.08%) ⬆️
...ubrix/labeling/text_classification/label_errors.py 90.36% <0.00%> (+3.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon merged commit dece436 into releases/0.x Oct 3, 2022
@frascuchon frascuchon deleted the bugfixes/resolve-1658-problems branch October 3, 2022 21:04
frascuchon added a commit that referenced this pull request Oct 3, 2022
* fix: align agents for predictions annotations

* fix: empty agent for annotations dict but check it on single annotation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant