Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfixes/review pr 1687 #1745

Merged
merged 24 commits into from Oct 5, 2022
Merged

Bugfixes/review pr 1687 #1745

merged 24 commits into from Oct 5, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Oct 3, 2022 •
edited

Some changes related to the usage telemetry:

  • Passing system data as event context (will simplify later integrations)
  • Show warning message on server start to clear preventing users
  • Include the Telemetry section inside the Reference doc.

@codecov
Copy link

codecov bot commented Oct 3, 2022 •
edited

Codecov Report

Base: 95.03% // Head: 95.02% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (bfd1b95) compared to base (98b9d7a).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@               Coverage Diff                @@
##           releases/0.x    #1745      +/-   ##
================================================
- Coverage         95.03%   95.02%   -0.01%     
================================================
  Files               148      148              
  Lines              6825     6837      +12     
================================================
+ Hits               6486     6497      +11     
- Misses              339      340       +1
Flag Coverage Δ
pytest 95.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/commons/telemetry.py 88.52% <100.00%> (-0.37%) ⬇️
src/rubrix/server/server.py 95.45% <100.00%> (+1.11%) ⬆️
src/rubrix/client/sdk/commons/errors_handler.py 86.20% <0.00%> (-3.45%) ⬇️
src/rubrix/server/errors/api_errors.py 100.00% <0.00%> (ø)
src/rubrix/server/errors/base_errors.py 98.61% <0.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon
Copy link
Member Author

@dvsrepo Please, provided a warning message for the server startup telemetry check

frascuchon and others added 17 commits October 3, 2022 23:07
@frascuchon
feat(Client): validate token classification annotations in client (#1709
ff6bfa2 
)

Closes #1579

(cherry picked from commit 6d82717)
@frascuchon
feat(Datasets): restrict dataset deletion only to creators and super-…
3cd1e3a 
…users (#1713)

* feat(Datasets): restrict dataset deletion only to creators and super-users

* tests: add tests for datasets deletion check

* chore: improve deletion error message

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

* Format long strings

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

(cherry picked from commit c5ab270)
fix: handle separately 401 and 403 api errors in UI (#1740)

Since the changes included in #1713, users without permission trying to delete datasets from UI will hit into a re-login operation.

This PR handles separate authentication errors (401) and forbidden errors (403).

We should find a better way to handle error codes and info in general.
@frascuchon
ci: set a proper cleanlab version for tests
202df1a 
(cherry picked from commit 7272d60)
@frascuchon
feat(Datasets): delete records by query (#1721)
f066518 
Closes #1714

(cherry picked from commit be4e92c)

fix: delete records feature (#1737)

Some problems detected:

Change from httpx.delete to httpx.request with method="DELETE", since the delete method does not accept body param (data or json)
Fix response data when no records match for deletion
@frascuchon
ci: HF tests only for master and releases branches (#1720)
da35728 
Since several memory errors occurs running test related to the hf hub, those tests will be only launched for master and release branches.

Test for contributors' branches can be executed without problems.

(cherry picked from commit d75675e)
@frascuchon
ci: closing inactive issues (#1716)
91d2359 
* ci: closing inactive issues

* exclude some issues by tag

(cherry picked from commit 58b99c1)
@frascuchon
ci: automatic insert license header (#1710)
5a36849 
* ci: auto insert license-header

* ci: add insert-headers pre-commit

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* ci: add missing license header

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit cd24d7d)
@Ankush-Chander @frascuchon
refactor: accept flat text as input for token classification mapper (#…
19acc1a 
…1686)

Closes #482

(cherry picked from commit 379ac56)
@frascuchon
feat(Client): expose client extra headers in init function (#1715)
d973eac 
* feat(Client): expose client extra headers in init function

* tests: adding missing tests

* docs: include some example of how to use additional headers

* Apply suggestions from code review

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Co-authored-by: Daniel Vila Suero <daniel@recogn.ai>

Closes #1706

(cherry picked from commit 994494f)
@leiyre @frascuchon
style: Align App UI with the design system (#1672)
5bd7586 
This PR adds entity label component in entities selector, also includes kebab-case in some nuxt-link

* rename core folder to base

* fix checkbox margin

* remove unused prop

* decorator

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix copy text

* force commit

* update test snapshot

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Closes #1670

(cherry picked from commit 52bbceb)
@dvsrepo @frascuchon
docs: Add interpret tutorial with Transformers (#1728)
82fe331 
* docs(explain): add model interpret tutorials

* docs(explain): polish tuto

* docs(explain): polish tuto 2

* docs(explain): add explain to explanation

* docs(explain): add deps

* revert files

* revert file

Closes #1729

(cherry picked from commit 47645d9)
@pre-commit-ci @frascuchon
[pre-commit.ci] pre-commit autoupdate (#1712)
3af102f 
* [pre-commit.ci] pre-commit autoupdate

updates:
- [github.com/pre-commit/pre-commit-hooks: v2.3.0 → v4.3.0](pre-commit/pre-commit-hooks@v2.3.0...v4.3.0)
- [github.com/psf/black: 21.9b0 → 22.8.0](psf/black@21.9b0...22.8.0)
- [github.com/pycqa/isort: 5.9.3 → 5.10.1](PyCQA/isort@5.9.3...5.10.1)
- [github.com/alessandrojcm/commitlint-pre-commit-hook: v2.2.0 → v9.1.0](alessandrojcm/commitlint-pre-commit-hook@v2.2.0...v9.1.0)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
(cherry picked from commit a9076dc)
@frascuchon
chore: upgrade version
4e78d79
@frascuchon
docs: fixing the active learning tutorial with small-text (#1726)
a64fd6c 
* docs: fixing the active learning tutorial with `small-text`

* docs: using a tiny model

* docs: Change tutorial title

* docs: Change active learning title in card

(cherry picked from commit f4f2289)

Closes #1693
@keithCuniah @frascuchon
fix: search tag reset prior annotation (#1736)
66bb9c0 
Closes #1711

Also, add some none regression unit test with Jest

(cherry picked from commit fcd6c81)
@frascuchon
docs: using official token class. mapper since is compatible now (#1738)
f62dc23 
Once the issue #482 is resolved, we can remove the custom mapper for spacy on this tutorial and use the one provided by the monitoring module.
@frascuchon
chore: frontend version
9c309d3
@frascuchon frascuchon merged commit 7bb34ad into releases/0.x Oct 5, 2022
@frascuchon frascuchon deleted the bugfixes/review-pr-1687 branch October 5, 2022 13:59
frascuchon added a commit that referenced this pull request Oct 5, 2022
@frascuchon
fix: Review features for server telemetry (#1745)
3a27500 
Some changes related to the usage telemetry:

- Passing system data as event context (will simplify later integrations)
- Show warning message on server start to clear preventing users
- Include the Telemetry section inside the Reference doc.

Refs: #1687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvsrepo dvsrepo Awaiting requested review from dvsrepo

@davidberenstein1957 davidberenstein1957 Awaiting requested review from davidberenstein1957

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@frascuchon @dvsrepo @Ankush-Chander @leiyre @keithCuniah