Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixes/review pr 1709 #1746

Merged
merged 1 commit into from Oct 4, 2022
Merged

Bugfixes/review pr 1709 #1746

merged 1 commit into from Oct 4, 2022

Conversation

frascuchon
Copy link
Member

With this change, errors will be shown as following:

ValueError: Following entity spans are not aligned with provided tokenization
Spans:
- [Th] defined in This is...
- [his is] defined in This is a te...
- [is a text in Ja] defined in This is a text in Japan. ...
- [a t] defined in ...s is a text i...
Tokens
['This', 'is', 'a', 'text', 'in', 'Japan', '.', 'And', 'This', 'too', 'but', 'for', 'Paris']

@frascuchon frascuchon changed the title Improve misaligned error messages Bugfixes/review-pr-1709 Oct 3, 2022
@frascuchon frascuchon changed the title Bugfixes/review-pr-1709 Bugfixes/review pr 1709 Oct 3, 2022
@frascuchon frascuchon linked an issue Oct 3, 2022 that may be closed by this pull request
4 tasks
@frascuchon
Copy link
Member Author

frascuchon commented Oct 3, 2022

@dvsrepo Please, take a look into the error message format and do some local tests with it.

Copy link
Member

@dvsrepo dvsrepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 95.02% // Head: 95.15% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (ea2a6c9) compared to base (9c309d3).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           releases/0.x    #1746      +/-   ##
================================================
+ Coverage         95.02%   95.15%   +0.12%     
================================================
  Files               148      148              
  Lines              6815     6825      +10     
================================================
+ Hits               6476     6494      +18     
+ Misses              339      331       -8     
Flag Coverage Δ
pytest 95.15% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/utils/span_utils.py 100.00% <100.00%> (ø)
...ubrix/labeling/text_classification/label_errors.py 100.00% <0.00%> (+9.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon merged commit beea194 into releases/0.x Oct 4, 2022
@frascuchon frascuchon deleted the bugfixes/review-pr-1709 branch October 4, 2022 11:10
frascuchon added a commit that referenced this pull request Oct 4, 2022
)

Closes #1579

(cherry picked from commit 6d82717)

fix: Improve misaligned error message (#1746)
frascuchon added a commit that referenced this pull request Oct 5, 2022
)

Closes #1579

(cherry picked from commit 6d82717)

fix: Improve misaligned error message (#1746)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usage telemetry
2 participants