Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove the tedious message about loguru #1770

Merged
merged 1 commit into from Oct 21, 2022

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Oct 14, 2022

When loguru is not found in the system, a message is shown again and again. This PR just removes the message.

For future versions, we can include better logging customization that can be explicitly enabled.

See #1305

Could we create an issue and label it as a good first issue?

cc @davidberenstein1957 @dvsrepo

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Base: 94.67% // Head: 94.53% // Decreases project coverage by -0.14% ⚠️

Coverage data is based on head (748708e) compared to base (06d325b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff                @@
##           releases/1.x    #1770      +/-   ##
================================================
- Coverage         94.67%   94.53%   -0.15%     
================================================
  Files               149      149              
  Lines              6917     6916       -1     
================================================
- Hits               6549     6538      -11     
- Misses              368      378      +10     
Flag Coverage Δ
pytest 94.53% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/argilla/logging.py 87.27% <ø> (+1.55%) ⬆️
...gilla/labeling/text_classification/label_errors.py 86.74% <0.00%> (-13.26%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon merged commit b80c175 into releases/1.x Oct 21, 2022
@frascuchon frascuchon deleted the refactor/remove-tedious-loguru-warning branch October 21, 2022 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants