New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Reposition help info button #1823

Closed

leiyre wants to merge 36 commits into main from bugfixes/explanation_help

Member

leiyre commented Nov 4, 2022 •

edited

This PR removes "Help explain button" in Manage rule view and includes a new button position

closes #1807
closes #1877

leiyre added 5 commits

November 3, 2022 12:21


          remove explain help from

9d9893d


          include styles


          include "view-info" button in sidebar

30b0e2a


          update test

a85651a


          test

456b3c9

leiyre requested review from frascuchon and keithCuniah

November 4, 2022 14:25

keithCuniah reviewed

View reviewed changes

frontend/components/commons/sidebar/SidebarButton.vue Outdated Show resolved Hide resolved

keithCuniah reviewed

View reviewed changes

frontend/components/commons/sidebar/SidebarButton.vue Show resolved Hide resolved

keithCuniah reviewed

View reviewed changes

frontend/components/commons/sidebar/SidebarMenu.vue Outdated Show resolved Hide resolved

keithCuniah reviewed

View reviewed changes

frontend/components/commons/sidebar/SidebarMenu.vue Outdated Show resolved Hide resolved

keithCuniah reviewed

View reviewed changes

frontend/components/commons/sidebar/SidebarMenu.vue Show resolved Hide resolved

keithCuniah reviewed

View reviewed changes

frontend/components/commons/sidebar/TaskSidebar.vue Outdated Show resolved Hide resolved

keithCuniah reviewed

View reviewed changes

frontend/components/text-classifier/sidebar/TextClassificationViewInfo.vue Outdated Show resolved Hide resolved

keithCuniah reviewed

View reviewed changes

frontend/components/text-classifier/sidebar/TextClassificationViewInfo.vue Outdated Show resolved Hide resolved

leiyre added 8 commits

November 7, 2022 11:01


          rename prop

ff50061


          refactor duplicated operation

c383096


          move template logic to computed

c319c07


          restructure and refactor styles

dbe92ce


          use template literals

47ad604


          replace visibleViewInfo === true by visibleViewInfo

0256a05


          include default value

f846630


          rename computed property

870cdfd

leiyre requested a review from keithCuniah

November 7, 2022 10:43

keithCuniah approved these changes

View reviewed changes

leiyre added 5 commits

November 8, 2022 16:34


          include text in modal

ae289ac


          lint and update test

b248794


          prevent undefined component

b98cc1d


          refactor modal

01cedca


          include title as prop

e9e0e81

leiyre added 7 commits

November 10, 2022 10:35


          update test

c21bf87


          lint

9aa0c47


          update test

e32daf6


          add position and remove unused code

cfe4e04


          update test

357cd32


          fix position

4fadc7e


          fix position

3a2ee71

This was linked to issues Nov 14, 2022

UI: Remove "Help explain button" in Manage rule view #1807

Closed

UI: Create an "info" button to support the user in the different views #1877

Closed

leiyre added 7 commits

November 15, 2022 14:40


          remove record-counter and include records word in the pagination


          include dataset options component

d57eb5e


          include help info component

7cbf78d


          remove old logic

e21ffbd


          refactor button styles

1efa26a


          add styles and refactor modal

470928e


          update test

ef2440f

leiyre changed the title ~~fix: Move explain info to sidebar~~ fix: Reposition help info button


          update test

60ccbdc

leiyre requested review from Amelie-V and removed request for frascuchon

November 15, 2022 15:42

leiyre added 2 commits

November 15, 2022 16:49


          lint

bbed224


          update test

e74e2cb

Member

frascuchon commented Nov 15, 2022

@leiyre this PR should be separated into two different ones:

PR with the bugfix to the main branch and closing UI: Remove "Help explain button" in Manage rule view #1807
PR with the new feat. to the develop branch, closing UI: Create an "info" button to support the user in the different views #1877

Otherwise, if we decide to release a patch version, issue #1807 couldn't be fixed since we cannot isolate in a single commit the bugfix

Member Author

leiyre commented Nov 16, 2022

@leiyre this PR should be separated into two different ones:

PR with the bugfix to the main branch and closing UI: Remove "Help explain button" in Manage rule view #1807

PR with the new feat. to the develop branch, closing UI: Create an "info" button to support the user in the different views #1877

Otherwise, if we decide to release a patch version, issue #1807 couldn't be fixed since we cannot isolate in a single commit the bugfix

@frascuchon ok, I will open one for the first point (bug) and other one for the second point (feat)

This was unlinked from issues Nov 16, 2022

UI: Remove "Help explain button" in Manage rule view #1807

Closed

UI: Create an "info" button to support the user in the different views #1877

Closed

Member Author

leiyre commented Nov 16, 2022

this PR has been subdivided into #1909 and #1913

leiyre closed this

leiyre deleted the bugfixes/explanation_help branch

November 16, 2022 15:55

Member

frascuchon commented Nov 16, 2022

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment