Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable metadata length field config by environment variable #1923

Merged
merged 7 commits into from
Nov 22, 2022

Conversation

frascuchon
Copy link
Member

Closes #1761

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Base: 94.59% // Head: 94.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8a60223) compared to base (8aec980).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1923   +/-   ##
========================================
  Coverage    94.59%   94.59%           
========================================
  Files          149      150    +1     
  Lines         7025     7036   +11     
========================================
+ Hits          6645     6656   +11     
  Misses         380      380           
Flag Coverage Δ
pytest 94.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/argilla/server/daos/backend/elasticsearch.py 86.03% <ø> (ø)
src/argilla/_constants.py 100.00% <100.00%> (ø)
src/argilla/_messages.py 100.00% <100.00%> (ø)
src/argilla/client/models.py 94.14% <100.00%> (+0.22%) ⬆️
.../argilla/client/sdk/token_classification/models.py 100.00% <100.00%> (ø)
...rc/argilla/server/daos/backend/mappings/helpers.py 98.46% <100.00%> (-0.03%) ⬇️
src/argilla/server/daos/models/records.py 97.16% <100.00%> (+0.14%) ⬆️
...server/services/tasks/text_classification/model.py 99.32% <100.00%> (ø)
...erver/services/tasks/token_classification/model.py 98.97% <100.00%> (-0.04%) ⬇️
src/argilla/server/settings.py 76.66% <100.00%> (+0.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frascuchon frascuchon force-pushed the feature/enable-metadata-lenght-field-config branch from 3c83eab to 8a60223 Compare November 21, 2022 10:21
@frascuchon frascuchon merged commit 0ff2de7 into develop Nov 22, 2022
@frascuchon frascuchon deleted the feature/enable-metadata-lenght-field-config branch November 22, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Configuration] Allow configure max length for metadata fields
2 participants