feat: add login command
#3600
Merged
feat: add login command
#3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarobartt
approved these changes
Aug 21, 2023
src/argilla/tasks/login/__main__.py
Outdated
| app = typer.Typer(invoke_without_command=True) | ||
|
|
||
|
|
||
| @app.callback(help="Login to an Argilla server") |
There was a problem hiding this comment.
Suggested change
| @app.callback(help="Login to an Argilla server") | |
| @app.callback(help="Login into an Argilla Server") |
src/argilla/tasks/login/__main__.py
Outdated
Comment on lines
24
to
30
| api_url: str = typer.Option(..., help="The URL of the Argilla server to login"), | ||
| api_key: str = typer.Option(..., help="The API key to use to login to the Argilla server", prompt="API Key"), | ||
| workspace: Optional[str] = typer.Option( | ||
| None, help="The default workspace over which the operations will be performed" | ||
| ), | ||
| extra_headers: Optional[str] = typer.Option( | ||
| None, help="A JSON string with extra headers to be sent in the requests to the Argilla server" |
There was a problem hiding this comment.
Suggested change
| api_url: str = typer.Option(..., help="The URL of the Argilla server to login"), | |
| api_key: str = typer.Option(..., help="The API key to use to login to the Argilla server", prompt="API Key"), | |
| workspace: Optional[str] = typer.Option( | |
| None, help="The default workspace over which the operations will be performed" | |
| ), | |
| extra_headers: Optional[str] = typer.Option( | |
| None, help="A JSON string with extra headers to be sent in the requests to the Argilla server" | |
| api_url: str = typer.Option(..., help="The URL of the Argilla Server to login into"), | |
| api_key: str = typer.Option(..., help="The API key to use to login into the Argilla Server", prompt="API Key"), | |
| workspace: Optional[str] = typer.Option( | |
| None, help="The default workspace over which the operations will be performed" | |
| ), | |
| extra_headers: Optional[str] = typer.Option( | |
| None, help="A JSON string with extra headers to be sent in the requests to the Argilla Server" |
|
The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3600-ki24f765kq-no.a.run.app |
Co-authored-by: alvarobartt <alvaro@argilla.io>
artikandri
pushed a commit
to CLARIN-PL/argilla
that referenced
this pull request
Oct 30, 2023
# Description This PR adds the `login` command that will allow to login in an Argilla server and store the credentials locally so they can be used later when calling `rg.init` or other CLI commands. In addition, a `init_callback` function has been added to be reused as callback function for the groups of commands that needs to "login" before getting executed. Closes argilla-io#3584 **Type of change** - [x] New feature (non-breaking change which adds functionality) **How Has This Been Tested** Tested manually in a local development environment and added tests to cover the additions and changes. **Checklist** - [ ] I added relevant documentation - [x] I followed the style guidelines of this project - [x] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [x] My changes generate no new warnings - [x] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [x] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/) --------- Co-authored-by: alvarobartt <alvaro@argilla.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
logincommand that will allow to login in an Argilla server and store the credentials locally so they can be used later when callingrg.initor other CLI commands.In addition, a
init_callbackfunction has been added to be reused as callback function for the groups of commands that needs to "login" before getting executed.Closes #3584
Type of change
How Has This Been Tested
Tested manually in a local development environment and added tests to cover the additions and changes.
Checklist
CHANGELOG.mdfile (See https://keepachangelog.com/)