Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add RemoteResponseSchema.{inserted_at,updated_at} fields #3822

Merged
merged 4 commits into from
Oct 10, 2023

Conversation

alvarobartt
Copy link
Member

@alvarobartt alvarobartt commented Sep 26, 2023

Description

This PR adds both inserted_at and updated_at fields to RemoteResponseSchema to use those values that were previously discarded when pulling the responses from the API, which is useful for further analysis as requested by @davidberenstein1957.

Closes #3820

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

  • Add unit tests for both inserted_at and updated_at fields in RemoteResponseSchema

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@alvarobartt alvarobartt self-assigned this Sep 26, 2023
@alvarobartt alvarobartt added type: enhancement Indicates new feature requests client labels Sep 26, 2023
@alvarobartt alvarobartt added this to the v1.17.0 milestone Sep 26, 2023
@alvarobartt alvarobartt marked this pull request as ready for review September 26, 2023 10:25
@github-actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-3822-ki24f765kq-no.a.run.app

@gabrielmbmb gabrielmbmb merged commit a613323 into develop Oct 10, 2023
27 checks passed
@gabrielmbmb gabrielmbmb deleted the feat/add-response-datetimes branch October 10, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] add datetime to ResponseSchema
2 participants