Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Review username regex pattern #4544

Merged
merged 6 commits into from
Jan 29, 2024
Merged

refactor: Review username regex pattern #4544

merged 6 commits into from
Jan 29, 2024

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Jan 29, 2024 •
edited
Loading

Description

This PR reviews the username pattern to be more flexible without losing API functionality.

  • Upper case letters are allowed
  • Starting by number is allowed

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

Running locally

  • Test A
  • Test B

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon self-assigned this Jan 29, 2024
@frascuchon frascuchon marked this pull request as ready for review January 29, 2024 12:22
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. area: server Indicates that an issue or pull request is related to the server language: python Pull requests or issues that update Python code team: backend Indicates that the issue or pull request is owned by the backend team type: improvement Indicates updates or improvements on existing features labels Jan 29, 2024
@frascuchon frascuchon changed the title refactor: Review username regex pattern refactor: Review username regex pattern Jan 29, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 29, 2024
jfcalvo
jfcalvo reviewed Jan 29, 2024
View reviewed changes
tests/unit/server/security/test_model.py Outdated


@pytest.mark.parametrize(
"invalid_username", ["user name", "user/name", "user.name", "_", "-", "123_", "1234-", "---32", "_mark", "-mark"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding a just number username example?

@github-actions GitHub Actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4544-ki24f765kq-no.a.run.app

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 29, 2024
@frascuchon frascuchon merged commit 7de1233 into feature/oauth-integration Jan 29, 2024
12 of 16 checks passed
@frascuchon frascuchon deleted the refactor/review-username-regex-pattern branch January 29, 2024 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfcalvo jfcalvo jfcalvo approved these changes

@gabrielmbmb gabrielmbmb gabrielmbmb approved these changes

Assignees

@frascuchon frascuchon

Labels
area: server Indicates that an issue or pull request is related to the server language: python Pull requests or issues that update Python code lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files. team: backend Indicates that the issue or pull request is owned by the backend team type: improvement Indicates updates or improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@frascuchon @jfcalvo @gabrielmbmb