Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: relax pandas constraint version to allow for >2.0 #4600

Merged
merged 8 commits into from
Feb 27, 2024

Conversation

davidberenstein1957
Copy link
Member

Description

It seems our usage of Pandas does not require any change w.r.t. upgrading to 2.0.

Closes #4599

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

N.A.

Checklist

@davidberenstein1957 davidberenstein1957 linked an issue Feb 22, 2024 that may be closed by this pull request
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. area: python sdk Indicates that an issue or pull request is related to the Python SDK language: python Pull requests or issues that update Python code team: backend Indicates that the issue or pull request is owned by the backend team type: improvement Indicates updates or improvements on existing features labels Feb 22, 2024
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4600-ki24f765kq-no.a.run.app

@davidberenstein1957 davidberenstein1957 changed the title feat: bump pandas version to 2.0 feat: relax pandas constraint version to allow for >2.0 Feb 22, 2024
@dosubot dosubot bot added this to the v1.25.0 milestone Feb 22, 2024
@jfcalvo jfcalvo mentioned this pull request Feb 22, 2024
16 tasks
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 23, 2024
frascuchon added a commit that referenced this pull request Feb 26, 2024
# Description

Check if problems found at PR
#4600 are associated to
latests changes on `argilla-server` repository.

**Type of change**

(Please delete options that are not relevant. Remember to title the PR
according to the type of change)

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to not work as expected)
- [ ] Refactor (change restructuring the codebase without changing
functionality)
- [ ] Improvement (change adding some improvement to an existing
functionality)
- [ ] Documentation update

**How Has This Been Tested**

(Please describe the tests that you ran to verify your changes. And
ideally, reference `tests`)

- [ ] Test A
- [ ] Test B

**Checklist**

- [ ] I added relevant documentation
- [ ] follows the style guidelines of this project
- [ ] I did a self-review of my code
- [ ] I made corresponding changes to the documentation
- [ ] My changes generate no new warnings
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK)
(see text above)
- [ ] I have added relevant notes to the CHANGELOG.md file (See
https://keepachangelog.com/)

---------

Co-authored-by: Paco Aranda <francis@argilla.io>
Co-authored-by: Damián Pumar <damianpumar@gmail.com>
Co-authored-by: leire <leire@recogn.ai>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Feb 27, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.04%. Comparing base (03e0f99) to head (7d81b31).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4600       +/-   ##
============================================
+ Coverage    45.28%   89.04%   +43.76%     
============================================
  Files          190      190               
  Lines        11673    11667        -6     
============================================
+ Hits          5286    10389     +5103     
+ Misses        6387     1278     -5109     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 27, 2024
@frascuchon frascuchon merged commit cc32f67 into develop Feb 27, 2024
16 checks passed
@frascuchon frascuchon deleted the feat/4599-why-pandas-=100200-dependency-is-used branch February 27, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: python sdk Indicates that an issue or pull request is related to the Python SDK language: python Pull requests or issues that update Python code lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. team: backend Indicates that the issue or pull request is owned by the backend team type: improvement Indicates updates or improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why "pandas >=1.0.0,<2.0.0" dependency is used?
2 participants