Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: mention ARGILLA_AUTH_SECRET_KEY in docker-compose deployment #4639

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

davidefiocco
Copy link
Contributor

@davidefiocco davidefiocco commented Mar 7, 2024

Description

I'm proposing to add a mention to the var ARGILLA_AUTH_SECRET_KEY introduced in #4539 to the docker-compose-related documentation in docs/_source/getting_started/installation/deployments/docker_compose.md

As far as I am aware, that env var needs to be set in order to run the service in docker-compose.

It's a small edit, I didn't create (yet) an issue for this.

  • Documentation update

How Has This Been Tested

  • sphinx-autobuild

I didn't run sphinx! I had troubles w/ cloning, will update this as soon as I can

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. severity: minor Indicates that the issue isn't urgent or blocking team: backend Indicates that the issue or pull request is owned by the backend team type: documentation Improvements or additions to documentation labels Mar 7, 2024
@davidberenstein1957
Copy link
Member

@davidefiocco thanks for the PR. I updated the phrasing a bit and will merge it now :)

@davidberenstein1957 davidberenstein1957 merged commit 853ff20 into argilla-io:develop Mar 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity: minor Indicates that the issue isn't urgent or blocking size:XS This PR changes 0-9 lines, ignoring generated files. team: backend Indicates that the issue or pull request is owned by the backend team type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants