Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix reversed string #4753

Merged
merged 3 commits into from
Apr 30, 2024
Merged

🐛 Fix reversed string #4753

merged 3 commits into from
Apr 30, 2024

Conversation

damianpumar
Copy link
Contributor

No description provided.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 26, 2024
@damianpumar damianpumar linked an issue Apr 26, 2024 that may be closed by this pull request
[BUG-UI/UX] Search queries in korean get flipped (FeedbackDataset) #4733
Closed
@damianpumar damianpumar self-assigned this Apr 26, 2024
@dosubot dosubot bot added area: ui Indicates that an issue or pull request is related to the User Interface (UI) language: javascript Pull requests or issues that update Javascript code severity: minor Indicates that the issue isn't urgent or blocking team: frontend Indicates that the issue or pull request is owned by the frontend team type: bug Indicates an unexpected problem or unintended behavior labels Apr 26, 2024
@github-actions GitHub Actions
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4753-ki24f765kq-no.a.run.app

nataliaElv
nataliaElv approved these changes Apr 26, 2024
View reviewed changes
Copy link
Member

@nataliaElv nataliaElv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it's working! Thanks @damianpumar ! 🙌

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 26, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 30, 2024
@damianpumar damianpumar merged commit 1ee1dda into develop Apr 30, 2024
11 checks passed
@damianpumar damianpumar deleted the fix/korean-chars-reversed branch April 30, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nataliaElv nataliaElv nataliaElv approved these changes

@leiyre leiyre Awaiting requested review from leiyre

Assignees

@damianpumar damianpumar

Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) language: javascript Pull requests or issues that update Javascript code lgtm This PR has been approved by a maintainer severity: minor Indicates that the issue isn't urgent or blocking size:S This PR changes 10-29 lines, ignoring generated files. team: frontend Indicates that the issue or pull request is owned by the frontend team type: bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG-UI/UX] Search queries in korean get flipped (FeedbackDataset)
2 participants
@damianpumar @nataliaElv