Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add branches and tags to argilla-server.yml GitHub workflow #4854

Merged
merged 2 commits into from
May 20, 2024

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented May 20, 2024

Description

I have added a tags and branches section to the Argilla server GitHub workflow so docker images are generated when a push is done to main and develop branches or a new tag is pushed to the repo.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)
  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Docker images should be uploaded to Docker Hub for main and develop branches.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon May 20, 2024 09:31
Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.94%. Comparing base (6630d7b) to head (74a46ba).
Report is 792 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4854      +/-   ##
===========================================
+ Coverage    90.13%   90.94%   +0.80%     
===========================================
  Files          233      205      -28     
  Lines        12493    10082    -2411     
===========================================
- Hits         11261     9169    -2092     
+ Misses        1232      913     -319     
Flag Coverage Δ
argilla-server 90.94% <100.00%> (?)
pytest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo merged commit df56c15 into develop May 20, 2024
8 checks passed
@jfcalvo jfcalvo deleted the fix/add-branches-and-tags-to-argilla-server-workflow branch May 20, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants