Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Filter record metadata value based on metadata property policies #4906

Conversation

frascuchon
Copy link
Member

Description

This PR fixes metadata visibility errors when fetching records for a user.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I followed the style guidelines of this project
  • I did a self-review of my code
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon requested a review from jfcalvo May 29, 2024 12:59
@frascuchon frascuchon changed the title Bugfix/filter record metadata value based on policies [BUGFIX] Filter record metadata value based on policies May 29, 2024
@frascuchon frascuchon changed the title [BUGFIX] Filter record metadata value based on policies [BUGFIX] Filter record metadata value based on metadata property policies May 29, 2024
Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.97%. Comparing base (39b169c) to head (5a95c1b).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           releases/1.29.0    #4906       +/-   ##
====================================================
+ Coverage            66.65%   90.97%   +24.31%     
====================================================
  Files                  399      206      -193     
  Lines                21935    10117    -11818     
====================================================
- Hits                 14621     9204     -5417     
+ Misses                7314      913     -6401     
Flag Coverage Δ
argilla ?
argilla-server 90.97% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jfcalvo jfcalvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only concern is that this change potentially can add a lot of database queries to check for the metadata.

Apart from that it looks good to me.

@frascuchon frascuchon added this to the v1.29.0 milestone May 29, 2024
@frascuchon frascuchon merged commit 65e2627 into releases/1.29.0 May 29, 2024
11 checks passed
@frascuchon frascuchon deleted the bugfix/filter-record-metadata-value-based-on-policies branch May 29, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants