Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fastfit tutorial #4958

Merged
merged 1 commit into from
Jun 5, 2024
Merged

docs: fastfit tutorial #4958

merged 1 commit into from
Jun 5, 2024

Conversation

sdiazlor
Copy link
Contributor

@sdiazlor sdiazlor commented Jun 5, 2024

Description

Due to the problems with main, I prefer to recreate the PR in a clean branch. Here the notebook has been updated with the latest comments from the previous PR

Closes #4878

Type of change

(Remember to title the PR according to the type of change)

  • Documentation update

How Has This Been Tested

(Please describe the tests that you ran to verify your changes.)

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@sdiazlor
Copy link
Contributor Author

sdiazlor commented Jun 5, 2024

@davidberenstein1957 I recreated the PR from a clean branch just in case. Here all the comments are applied. Even if for the new SDK, we plan more simple, straightforward tutorials, I believe we can still add this to the old docs and create some content in the meantime.

Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. Thanks for the follow-up.

@sdiazlor sdiazlor merged commit eddbcb4 into main Jun 5, 2024
5 checks passed
@sdiazlor sdiazlor deleted the docs/new-branch-fastfit-tutorial branch June 5, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants