Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: expose load_rules from base module #866

Merged
merged 3 commits into from Jan 4, 2022
Merged

chore: expose load_rules from base module #866

merged 3 commits into from Jan 4, 2022

Conversation

frascuchon
Copy link
Member

Closes: #854

dcfidalgo
dcfidalgo reviewed Jan 3, 2022
View reviewed changes
Copy link
Contributor

@dcfidalgo dcfidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to tackle this, you're always faster :) Just one inline comment!

src/rubrix/labeling/text_classification/__init__.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 3, 2022 •
edited

Codecov Report

Merging #866 (6a735c0) into master (04b6e61) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   95.48%   95.48%           
=======================================
  Files         109      109           
  Lines        4190     4190           
=======================================
  Hits         4001     4001           
  Misses        189      189
Flag Coverage Δ
pytest 95.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/rubrix/labeling/text_classification/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 04b6e61...6a735c0. Read the comment docs.

@frascuchon
Update src/rubrix/labeling/text_classification/__init__.py
d29281a 
Co-authored-by: David Fidalgo <david@recogn.ai>
@frascuchon frascuchon merged commit 010a820 into master Jan 4, 2022
@frascuchon frascuchon deleted the chore/expose_load_rules_from_base_module branch January 4, 2022 09:58
dvsrepo added a commit that referenced this pull request Jan 11, 2022
@dvsrepo
Merge branch 'master' of https://github.com/recognai/rubrix
2adcf12 
* 'master' of https://github.com/recognai/rubrix:
  Docs: Updates Flair zeroshot tutorial (#887)
  removing wrong video (#885)
  Update readme (#883)
  fix(UI) Metrics value by default if no metric (#875)
  feat(metrics): add token level metrics for token classification from client (#849)
  UI: New rule metrics layout (#861)
  chore: expose load_rules from base module (#866)
frascuchon added a commit that referenced this pull request Jan 11, 2022
@frascuchon
chore: expose load_rules from base module (#866)
a13d989 
* chore: expose load_rules from base module

* Update src/rubrix/labeling/text_classification/__init__.py

Co-authored-by: David Fidalgo <david@recogn.ai>

* fix import

Co-authored-by: David Fidalgo <david@recogn.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvsrepo dvsrepo Awaiting requested review from dvsrepo

@dcfidalgo dcfidalgo Awaiting requested review from dcfidalgo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[rules] Expose load_rules at the parent module
2 participants
@frascuchon @dcfidalgo