Fix PrometheusTask could not be imported
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`__type__` attribute in `Task` base classes was not a `ClassVar` causing dataclasses inheriting from them to not be able to have non-default attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PrometheusTaskcouldn't be imported after a bug that was introduced in #177, in which a__type__attribute with a default value (either"labelling"or"generator") was added to theTasks base classes (PreferenceTaskandCritiqueTask) which should be aClassVar.This was not allowing to the
dataclasses inheriting from these classes to define non-default attributes causing the error described in #184.In addition this PR have added
PrometheusTasktodistilabel.tasks.__init__, so it can be imported usingfrom distilabel.tasks import PrometheusTask.