Fix PrometheusTask and UltraCMTask could not be chained with TextGenerationTask
#195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PrometheusTask` was not working when using as a `labeller` in a `Pipeline` with a `TextGenerationTask` as `generator`, because the input arguments of its `generate_prompt` method were not aligned.
|
Thanks a lot @gabrielmbmb ! I also noticed yesterday the UltraCM didn't return a Prompt like other tasks but a str. And also the Prometheus one had a hardcoded prompt format as llama, this would also cause issues integrating with the rest of the stack. I guess the reason is these OSS models are very sensitive to prompt templates but we need to discuss how to make this more interoperable or at least inform the user. In general this wouldn't have been overlooked, if we have added a meaningful example showing the full workflow and likewise adding a very brief doc piece. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The arguments of
generate_promptmethod for bothPrometheusTaskandUltraCMTaskclasses were not aligned with the ones generated by theTextGenerationTask, not allowing to have aPipelinewith ageneratorusing theTextGenerationTaskand alabellerusing eitherPrometheusTaskorUltraCMTask.In addition, all the
generate_promptmethods have been updated to accept extra keyword arguments and ignore them (**_). This is useful and convenient for the cases in which aDatasetcontains more columns than the required by the task. Before if the input dataset contained additional columns not used by the task it would cause an error.