Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add draft with social cards #197

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Add draft with social cards #197

merged 5 commits into from
Jan 5, 2024

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Dec 22, 2023

Description

I push this PR so we can take a look at the default social cards. I still need to discover how to add a custom description to all the cards. For the docs we have created in /docs folder we can write it directly in the .md file, but still need to know how to do it for the reference we have from the docstrings.

Would close #183

@plaguss plaguss self-assigned this Dec 22, 2023
@plaguss plaguss marked this pull request as ready for review January 2, 2024 10:06
@plaguss
Copy link
Contributor Author

plaguss commented Jan 2, 2024

I have added a sentence/small description for the main pages in our docs, for example:
image
The remaining pages will render with the default content:
image
Let me know what you think of those and we can iterate.

@plaguss plaguss requested review from dvsrepo, gabrielmbmb and alvarobartt and removed request for dvsrepo and gabrielmbmb January 2, 2024 10:11
Copy link
Member

@dvsrepo dvsrepo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@gabrielmbmb gabrielmbmb merged commit f29c969 into main Jan 5, 2024
4 checks passed
@gabrielmbmb gabrielmbmb deleted the docs/social-card branch January 5, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Add social card plugin
3 participants