Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to_argilla for CritiqueTask #198

Merged
merged 4 commits into from
Dec 27, 2023
Merged

Add to_argilla for CritiqueTask #198

merged 4 commits into from
Dec 27, 2023

Conversation

gabrielmbmb
Copy link
Member

@gabrielmbmb gabrielmbmb commented Dec 23, 2023

Description

This PR adds the to_argilla to the CritiqueTask. Taking into account that the implementation of the to_argilla for the CritiqueTask and PreferenceTask are the same, the implementation of the PreferenceTask was moved to a mixin used now by both classes.

@gabrielmbmb gabrielmbmb self-assigned this Dec 26, 2023
@gabrielmbmb gabrielmbmb marked this pull request as ready for review December 26, 2023 10:00
@gabrielmbmb gabrielmbmb linked an issue Dec 26, 2023 that may be closed by this pull request
@alvarobartt alvarobartt merged commit fe16a4b into main Dec 27, 2023
4 checks passed
@alvarobartt alvarobartt deleted the critique_to_argilla branch December 27, 2023 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Do Critique tasks support to_argilla?
2 participants