-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Anyscale endpoints #213
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but shouldn't we add a check to ensure that OpenAILLM
and AnyscaleLLM
are not used within the same Pipeline
? As AFAIK that would fail since the OPENAI_BASE_URL
is modified as well as the OPENAI_API_KEY
, right?
I guess it would work fine as long as we don't rely on the environment variables, right? But unsure on how that's internally handled by OpenAI, will the provided key via arg override whatever is on the environment variable? |
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Could we add some unit tests to the OpenAILLM
class similar to the ones from VertexAILLM
?
It seems that the arg variable takes precedence in the |
Description
This PR adds anyscale endpoints on top of the OpenAI integration.
Would close #121