Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checking valid inputs before calling _generate #216

Merged
merged 10 commits into from
Jan 5, 2024

Conversation

gabrielmbmb
Copy link
Member

Description

This PR updates the generate method of the LLM class to:

  1. Check which inputs are valid (have the required task.input_args_names keys) getting a list of the valid ones and a list containing the indices of the invalid ones.
  2. Call _generate with the list of valid inputs
  3. Fill the indices of the invalid inputs of the final list with empty LLMOutputs, as the LLM could not be executed for these inputs.

Close #208

@gabrielmbmb gabrielmbmb added the fix label Jan 5, 2024
@gabrielmbmb gabrielmbmb added this to the 0.3.0 milestone Jan 5, 2024
@gabrielmbmb gabrielmbmb self-assigned this Jan 5, 2024
@gabrielmbmb gabrielmbmb merged commit b1949b6 into main Jan 5, 2024
4 checks passed
@gabrielmbmb gabrielmbmb deleted the add_checking_valid_inputs branch January 5, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Labeller not always receives required input_args_names
2 participants