Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TogetherInferenceLLM tests #217

Merged
merged 5 commits into from
Jan 6, 2024
Merged

Conversation

alvarobartt
Copy link
Member

Description

This PR is a follow up of #215, to add some unit tests, as well as fixing a small issue when pulling the choices from the TogetherInferenceLLM output. Besides that, also the _generate method has been split in two functions, one to run the inference and parse the output for a single prompt named _generate_single_output and then the _generate one to handle the looping on top of the provided inputs and num_generations args.

As suggested by @gabrielmbmb, in order to reduce the complexity of the `_generate` method within the `TogetherInferenceLLM` class, a new method has been introduced to only run the inference over a single example.
@alvarobartt alvarobartt added this to the 0.3.0 milestone Jan 5, 2024
@alvarobartt alvarobartt self-assigned this Jan 5, 2024
Forgot to push in the previous PR...

Co-authored-by: Gabriel Martin <gabriel@argilla.io>
@gabrielmbmb gabrielmbmb merged commit 3c5fb70 into main Jan 6, 2024
4 checks passed
@gabrielmbmb gabrielmbmb deleted the together-inference-follow-up branch January 6, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants