Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE and add LICENSE_HEADER #221

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

davidberenstein1957
Copy link
Member

@davidberenstein1957 davidberenstein1957 commented Jan 8, 2024

We got this comment on X https://twitter.com/ImageDeeply/status/1743982093707710835
I copied the license file from https://github.com/argilla-io/argilla/edit/develop/LICENSE, which seems to work properly in the Argilla repo.

LICENSE Outdated Show resolved Hide resolved
Copy link
Member

@alvarobartt alvarobartt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, thanks! This would be a breaking change, since we inject the LICENSE on top of each file, could you create a LICENSE_HEADER with the previous stuff, and then change the path within .pre-commit-config.yaml so that's injected instead of LICENSE?

@alvarobartt alvarobartt changed the title Update LICENSE Update LICENSE and add LICENSE_HEADER Jan 9, 2024
@alvarobartt alvarobartt merged commit ba3891a into main Jan 9, 2024
4 checks passed
@alvarobartt alvarobartt deleted the fix/davidberenstein1957-patch-license branch January 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants