Fix rating parsing in RatingToArgillaMixin.to_argilla_record
#227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves a bug internally reported by @dvsrepo which was affecting the Argilla export of both the
CritiqueTaskandPreferenceTaskwhen the max rating was equal or higher to 10, as those were not parsed intointand replaced withNoneinstead. So on, this PR fixes that to pass theratings_valuesover to theto_argilla_recordwithinRatingToArgillaMixinso that the max rating value is calculated from it, as well as ensuring that the parsing tointis performed when the value is lower or equal to the max rating (before it was ignoring the equal ratings).Kudos to @dvsrepo for reporting internally.