-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ETA to progress bar and fix not showing the progress bar if irrelavant #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a quick and easy one haha. @ignacioct , if you want to tackle something else, feel free to pick something nice. Also, there is this tiny thing that you might have missed in the original issue? #243 (comment)
In the example above, we also see the "Rows labelled".
@davidberenstein1957 ups, didn't see it! I fixed it in the last push, so everything should be working now. |
🍻 @ignacioct. Could you check a simple example with OpenAI to see if it renders properly? After that we should be ready to go |
@plaguss do I need to set up an inference endpoint or is there a way to avoid that? I tried the model that the HF people used to test the serverless implementation, but it was giving me limit errors |
@ignacioct, I believe we can also only use a generator. Correct? |
we can use only the generator, but it would be nice to see if there is some problem with a complete pipeline, or at least a labelling pipeline using OpenAI. Does he have access to Open AI? |
@ignacioct there are some linting issues |
Closes #243
Script for trying the progress bar
With just this change, we obtain the following using the try script above:
Thanks @plaguss for all the doc, I owe you a beer! He was afraid that dealing with OpenAI's futures would break the progress, I still have to test that specifically.