Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved error with self instruct to argilla method #265

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Jan 17, 2024

Description

This PR fixes the error found by @ignacioct related to SelfInstructTask splitting the instructions by character in a sentence instead of the whole sentence.

Added a simple unit test for the check.

Closes #254

@plaguss
Copy link
Contributor Author

plaguss commented Jan 17, 2024

@ignacioct check if your tutorial runs properly and let me know when you can

@plaguss plaguss self-assigned this Jan 17, 2024
@davidberenstein1957 davidberenstein1957 added this to the 0.4.0 milestone Jan 17, 2024
@davidberenstein1957 davidberenstein1957 changed the title Fix error with self instruct to argilla method fix: resolved error with self instruct to argilla method Jan 17, 2024
@davidberenstein1957 davidberenstein1957 merged commit ddd834f into main Jan 17, 2024
4 checks passed
@davidberenstein1957 davidberenstein1957 deleted the fix-to-argilla-self-instruct branch January 17, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] SelfInstructTask's to_argilla is splitting the instructions word by word
2 participants