Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add customizable criteria for query generation in SelfInstructTask #269

Merged
merged 16 commits into from
Jan 18, 2024

Conversation

ignacioct
Copy link
Contributor

Closes #255 suggested by @davanstrien

I've tried with https://github.com/davanstrien/haiku-dpo/blob/main/01_generate_haiku_prompts.ipynb and works fine. I've updated the documentation with a generic example instead of a Haiku example, to be more consistent with the rest of the snippets, which are very generic. We could do a tutorial with some use cases, like the Haiku, to show off this new feature.

Thanks, @dvsrepo and @plaguss for showing me the way 💡

Copy link
Contributor

@plaguss plaguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! just the small comment to keep the original template intact by default

src/distilabel/tasks/text_generation/self_instruct.py Outdated Show resolved Hide resolved
Co-authored-by: Agus <agustin@argilla.io>
Copy link
Member

@davidberenstein1957 davidberenstein1957 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ignacioct @plaguss, for me now it is only implicitly possible to change these values but we don't provide any clear insights in the docs or pointers as to how to do that. Also, we need to make a reference to it within the docs.

@davidberenstein1957
Copy link
Member

@ignacioct maybe you can also add references or mention the jinaj2 templates when you tackle the customising task templates issue w.r.t. the documentation.

@ignacioct
Copy link
Contributor Author

Looks good.

@ignacioct @plaguss, for me now it is only implicitly possible to change these values but we don't provide any clear insights in the docs or pointers as to how to do that. Also, we need to make a reference to it within the docs.

@davidberenstein1957 I've added the docstring and docs changes, please tell me if we need further documentation

@ignacioct
Copy link
Contributor Author

@ignacioct maybe you can also add references or mention the jinaj2 templates when you tackle the customising task templates issue w.r.t. the documentation.

I'll do :)

@plaguss
Copy link
Contributor

plaguss commented Jan 18, 2024

Just some extra addition to the docs and done

@ignacioct
Copy link
Contributor Author

Ready for final review, and we can push @plaguss @davidberenstein1957

@davidberenstein1957
Copy link
Member

@ignacioct , can you add the custom task snippet(s) in another PR?

@plaguss
Copy link
Contributor

plaguss commented Jan 18, 2024

@ignacioct , can you add the custom task snippet(s) in another PR?

Do you mean to remove the case of the SelfInstructTask? I think it makes sense here as a case of customising that one specifically

@davidberenstein1957 davidberenstein1957 added this to the 0.4.0 milestone Jan 18, 2024
@davidberenstein1957 davidberenstein1957 changed the title Criteria for query generation in SelfInstructTask feat: add customizable criteria for query generation in SelfInstructTask Jan 18, 2024
@davidberenstein1957 davidberenstein1957 merged commit cb55007 into main Jan 18, 2024
4 checks passed
@davidberenstein1957 davidberenstein1957 deleted the feat/flexibility_selfinstruct branch January 18, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add more flexibilty in construction of the SelfInstructTask template
3 participants