Add functionality to push tasks to the HuggingFace hub and download them automatically. #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…feat/serializer
…label into feat/tasks-to-hub
There was a problem hiding this comment.
@plaguss looking good! Added some small comments?
Shouldn't we also test if we can actually push and pull from the hub.
Also, I think the classes for Test*TaskSerialization can be generalized a bit w.r.t. having the same base class and different init args.
| path_in_repo=TASK_FILE_NAME, | ||
| repo_id=repo_id, | ||
| repo_type="dataset", | ||
| token=kwargs.get("token"), |
There was a problem hiding this comment.
if None will this default to the HF token internally?
There was a problem hiding this comment.
The HfApi().upload_file function should take care of that on it's own, this is the same implementation we have in argilla to update the dataset card here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the functionality to push tasks to the hub and download them automatically if available. It will simplify working with
CustomDatasetand keep track of the tasks that come with them out of the box.An example can be seen here.
Closes #290.