feat: Add EvolComplexity and EvolQuality
#299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
docs are still WIP @plaguss |
plaguss
reviewed
Jan 25, 2024
plaguss
reviewed
Jan 25, 2024
gabrielmbmb
requested changes
Jan 30, 2024
|
Also, could we add a unit test covering the Evol Quality Task use of the method |
chore: re-use strings in tests chore: outlined initial tests chore: rename Evol*GeneratorTask to Evol*Task
| @@ -120,6 +116,16 @@ def test_evol_task(evolution_method: str, expected: str, instruct_type: object): | |||
| assert isinstance(task, instruct_type) | |||
| assert task.system_prompt == "" | |||
| if isinstance(expected, str): | |||
| print("---COSA") | |||
There was a problem hiding this comment.
what is happening here?
There was a problem hiding this comment.
ups, forgot to remove those, it's hard to find the differences from the prompts directly from pytest
Here it is: 7c309aa. If the tests pass, and the docs are correct, I'll merge it |
plaguss
deleted the
feat/295-feature-add-evolcomplexity-and-evolquality-tasks-from-deita
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
EvolComplexityTaskandEvolQualityTask.EvolComplexityTaskis focused on improving the complexity of instructions and is a special implementation ofEvolInstructwhere we don't allow for thebreadthevolution method.EvolQualityTaskis focused on improving the complexity ofgeneration/responses and is a more altered implementation ofEvolInstructwith evolution methods for["helpfulness", "relevance", "depth", "creativity", "details"].Closes #296
Closes #299