Review OllamaLLM and TogetherInferenceLLM
#305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @alvarobartt, thanks for the updates! maybe we should take these changes into account within this open issue: #301 (ollama shared a new client in python) |
|
Hi @plaguss, IMO we can tackle that in a separate PR, this PR was only a quick overview on the latest changes related to LLM implementations 👍🏻 |
plaguss
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reviews the recently included
OllamaLLMfixing some type-hints and making the URLs to GitHub point toollama/ollamainstead ofjmorganca/ollama, and removes the image models within Together inTogetherInferenceLLM.