Fix logging visualization of labeller pipelines #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvarobartt
reviewed
Jan 30, 2024
| ) | ||
|
|
||
| def _labelling_progress_func(advance=None) -> None: | ||
| labelling_progress_bar(advance=1) | ||
|
|
||
| _labelling_progress_func() |
There was a problem hiding this comment.
running the examples noticed that the progress_bar never reaches the last element, starts from 0 and doesn't reach the end otherwise. Also unrelated but for a single session in a notebook for example, the progress bar only appears once, that could be tackled in a different PR.
alvarobartt
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the problem with the logging of labelling pipelines mentioned in #274.
Also another problem with the
richprogress bar:It takes into account the rows, but should take into account the
batch_sizeto ensure it finishes