Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Task (minimal implementation) #347

Merged
merged 16 commits into from
Feb 21, 2024
Merged

Add Task (minimal implementation) #347

merged 16 commits into from
Feb 21, 2024

Conversation

alvarobartt
Copy link
Member

@alvarobartt alvarobartt commented Feb 19, 2024

Description

This PR adds the Task and TextGeneration classes, defining the custom behaviour for the Task and also TextGeneration which is the default task that basically runs the generation using an LLM and putting the results into a Python dictionary with a single key.

Note this is a minimal implementation of the Task and may be rewritten once the components of the Pipeline are ready.

What's missing?

  • LLM refactor to include the load method and to update the LLM.generate method
  • Decide whether {input,output}_mapping should be moved to Step.connect or as a Pipeline runtime arg

@alvarobartt alvarobartt self-assigned this Feb 19, 2024
@alvarobartt alvarobartt changed the title Add Task (WIP) Add Task (minimal implementation) Feb 20, 2024
@alvarobartt alvarobartt marked this pull request as ready for review February 20, 2024 09:01
Base automatically changed from pipeline_local_execution to core-refactor February 20, 2024 15:48
@alvarobartt alvarobartt merged commit c79aa0b into core-refactor Feb 21, 2024
4 checks passed
@alvarobartt alvarobartt deleted the task-poc branch February 21, 2024 08:55
@alvarobartt alvarobartt added this to the 1.0.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants