-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serialization for the new components #349
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and AFAIK you didn't touch any of the previously existing files which is nice because we may do a cleanup so that we remove the old stuff from core-refactor
to avoid having code that's not necessary anymore!
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I've left some comments to tackle before merging! Great work 💪🏻
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
Description
This PR adds methods to serialize to the
Step
,DAG
andBasePipeline
classes.It includes a new
test/integration
, for the moment just with a simple pipeline without LLMs to check the behaviour with something more complex than the unit tests, but we can remove those.