-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement caching mechanism for the pipelines #370
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…filename to the cache filenames
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the first version of caching for the
Pipeline
objects. It works by serializing and saving the pipeline content after eachStep
(runs as a callback after each process) finishes to a folder under~/.cache/distilabel/pipelines
:batch_manager.json
: Contains the serialized_BatchManager
, the object in charge of managing the batches internally in thePipeline
.pipeline.yaml
: Contains the serializedPipeline
in YAML format, which can be reused within the CLI (CLI withrun
command #403).data.jsonl
: Generations saved as ajsonl
file (this file may be modified or removed).The following example, written under the
tests/integrations
folder can be run as an example:The script runs the pipeline twice, taking a look at the logs should show the effect of passing through the cached batches. Currently, we cached only after a step finishes, but it can managed by the user. See for example the previous
GenerateResponse
step, which calls the_pipeline._cache
method before yielding it's results.This PR would close #389