Add AsyncOpenAI and update OpenAILLM accordingly
#381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pytest-asyncio` is required to run `asyncio` methods within `pytest`, and `nest-asyncio` to allow nested event loops, otherwise `asyncio.run` calls will fail
plaguss
approved these changes
Mar 5, 2024
Needs to be placed within each test i.e. `Task`, `LLM`, ...instead of all of those combined within the same file, which was done initially as the first approach, but now needs to be properly done.
gabrielmbmb
reviewed
Mar 5, 2024
gabrielmbmb
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
AsyncLLMadding a new abstract method to implement in its subclasses namedageneratethat expects a single input instead of a list of inputs in order to be able to parallelize the requests to the async-compatibleLLMsubclasses i.e.OpenAILLM. Also thegeneratemethod is implemented withinAsyncLLMso that the logic is handled already, meaning that only theasync agenerateneeds to be implemented for each subclass.Besides that, this PR updates the
OpenAILLMto useAsyncOpenAIinstead of the synchronousOpenAIclient.Finally, some docstrings have been included to both
AsyncLLMandOpenAILLM, as well as unit tests forOpenAILLM.Closes #380
Update
Additionally, this PR also solves a bug with the
field_validatorofOpenAILLM.api_key, read more about it at https://docs.pydantic.dev/latest/concepts/validators/#validation-of-default-values. And this PR also fixes theGlobalStepsince it was inheriting from_Stepinstead ofStep, so it was breaking.