-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GeneratorStep.process
validation in DAG
and smaller fixes
#435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi, LGTM! I made some small changes to reuse |
gabrielmbmb
approved these changes
Mar 18, 2024
To be able to use the runtime type-hints we will need to put `StepInput` outsie the `TYPE_CHECKING` Co-authored-by: Gabriel Martin <gabrielmbmb@users.noreply.github.com>
alvarobartt
force-pushed
the
generator-step-safe-check
branch
from
March 18, 2024 14:45
124137c
to
833ee37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a method within
DAG
named_validate_generator_step_process_signature
that validates that the providedprocess
method signature matches the expected one, which should contain theoffset
arg, and also theinputs
arg should not be there, otherwise, aValueError
will be raised during the validation.Closes #431
Additionally, this PR also tackles the following:
CombineColumns
docstringsYields
overReturns
in docstrings whereyield
is used instead ofreturn
Task
specific methods out of abstract_Task
, to avoid conflicts / collisions withGeneratorTask
that has a differentprocess
signature