-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AnthropicLLM
#444
Add AnthropicLLM
#444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sdiazlor! Thanks for the PR, there's a couple of things I've mentioned and some others I'd like to confirm as:
- Is there any way we can check whether the provided model is an existing one? Could we offer a listing or just call an API endpoint to get the list of existing models within Anthropic?
- Could you reply with an example using the
http_client
? Or just mentioning which are the scenarios where it's useful? Also note that there may be issues when serializing thehttp_client
if that appears to expect anhttpx.Client
instance
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
Co-authored-by: Alvaro Bartolome <alvaro@argilla.io>
@alvarobartt Thanks for your feedback. 1- We could do that by using something similar to this. Should we implement it?
2- They use it to customize the httpx client as follows, so yeah, maybe this is an issue for serialization. Not sure how you handled this in similar cases, or if you just decided to remove it.
|
TO DO: http issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, it looks good!. Just need a small update before merging.
Co-authored-by: Gabriel Martín Blázquez <gmartinbdev@gmail.com>
Closes #424