Fix Distiset after PushToHub and smaller fixes
#452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plaguss
approved these changes
Mar 20, 2024
Sometimes the value within a column is `None`, so adding `None` to `pa.null` is safer to capture those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue with the
Pipelines that have aGlobalStepasPushToHubat the end, and don't propagate theinputs, so that the cache for the last step will contain an empty file, so that the_create_datasetmethod will fail since there will be no data.Also
_create_datasetdocstring, andPipeline.runand_get_filenamereturn type-hints have been fixed. Besides that the_TYPE_MAPmapping to Parquet types has been updated to includetype(None): pa.null()(this could also be handled in a better way, but not sure).