Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve azure openai support #461

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

BramVanroy
Copy link
Contributor

  • Adds instructions how to use OpenAI services through Azure in README
  • Adds a minor typing improvement for an Azure client
  • Skip model checking for Azure models because the Azure client is a weird thing: instead of a model like "gpt4-0123" it requires the deployment name. So self.model can be any arbitrary string, so verifying it against supported models won't work.

@alvarobartt
Copy link
Member

Hi @BramVanroy thanks for this! We're about to close the refactor in the core-refactor branch, everything's new and refactored there, so we can either merge yours in main and adapt that ourselves to the refactored version, or you can do that yourself, whatever you feel is better 👍🏻 It should be straight forward to extend the OpenAILLM class to create a subclass for AzureOpenAILLM, but ping us if you have any doubt and willing to work on top of core-refactor, otherwise, we'll be happy to review this one! Thanks again

@BramVanroy
Copy link
Contributor Author

Hi @alvarobartt I do not have the time to work on this so preferably the path that takes the least effort from my side. :)

If you plan to write a subclass for OpenAI specifically for Azure, that could be even better because then users can pass in their api_version, endpoint, deployment name, etc. rather than have to pre-define the azure client.

@alvarobartt alvarobartt merged commit 1240852 into argilla-io:main Mar 28, 2024
@alvarobartt alvarobartt mentioned this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants