Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Enum to Dict[str, str] to avoid serialization errors during caching #482

Merged
merged 3 commits into from
Mar 26, 2024

Conversation

plaguss
Copy link
Contributor

@plaguss plaguss commented Mar 26, 2024

Description

This PR removes the following error y changing the Enum to Dict[str, str] in the EvolInstruct family of tasks:

image

@plaguss plaguss self-assigned this Mar 26, 2024
@plaguss plaguss added this to the 1.0.0 milestone Mar 26, 2024
Comment on lines +31 to +39
GENERATION_MUTATION_TEMPLATES = {
"FRESH_START": GENERATION_MUTATION_TEMPLATES_EVOL_INSTRUCT["FRESH_START"],
"CONSTRAINTS": GENERATION_MUTATION_TEMPLATES_EVOL_INSTRUCT["CONSTRAINTS"],
"DEEPENING": GENERATION_MUTATION_TEMPLATES_EVOL_INSTRUCT["DEEPENING"],
"CONCRETIZING": GENERATION_MUTATION_TEMPLATES_EVOL_INSTRUCT["CONCRETIZING"],
"INCREASED_REASONING_STEPS": GENERATION_MUTATION_TEMPLATES_EVOL_INSTRUCT[
"INCREASED_REASONING_STEPS"
],
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we can just simply GENERATION_MUTATION_TEMPLATES = GENERATION_MUTATION_TEMPLATES_EVOL_INSTRUCT.copy()

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't share the "BREADTH", we can let like this or copy and remove that field

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh my bad

@gabrielmbmb gabrielmbmb merged commit 448ffdb into core-refactor Mar 26, 2024
4 checks passed
@gabrielmbmb gabrielmbmb deleted the cache-enum branch March 26, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants