Update _WriteBuffer to write several parquet files
#483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
_WriteBufferto create several parquet files instead of just one using theParquetWriter. As we're inferring the schema using the first row added to the_WriteBuffer, we needed to check that schema for each batch is equal to the writer schema, and if it wasn't, create a new one unifying both schemas. This required closing theParquetWriterand reopening it with the new schema, but this overwrites the content of the parquet file, losing the data from previous steps.With this new approach, we write a parquet file (
00001.parquet,00002.parquet, etc) once the buffer for the step is full. The buffer will be considered to be full once the defined number of elements in the buffer is reached.