Fix huggingface_hub TextGenerationError import #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Wauplin thanks for the fix! No need to say sorry 馃 Also we're almost done with our refactor (it's going to be huge), but I'll adapt this later on in the |
|
Didn't know about the refactor so I'll leave this PR to you :) Feel free to close, merge or cherry-pick the changes 馃 |
alvarobartt
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #484.
The bug was introduced by a breaking change in
huggingface_hub==0.22.0. Sorry about that 馃槵 . This PR fixes it by importTextGenerationErrorfromhuggingface_hub.errorswhich is more future-proof.cc @davanstrien who pinged me on this