Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with spacy 3.0 #10

Merged
merged 3 commits into from Apr 13, 2021
Merged

Conversation

Hydroptix
Copy link
Contributor

@Hydroptix Hydroptix commented Mar 13, 2021

Not 100% sure if this is exactly what the PR should look like, but I can run the example test files successfully using spacy 3.0.5. Should still be backwards compatible with 2.0 using the old add_pipe method, but that isn't currently reflected in the README in my PR.

Make any edits as needed/let me know if I should update something.

Copy link

@spiritedawayseasong spiritedawayseasong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and working on my end

@frascuchon
Copy link
Member

Great @Hydroptix !! Thanks for your job!

I've just included a minimal reference for spacy 2.x initalization in README as you commented below

@frascuchon frascuchon merged commit e1d0641 into argilla-io:master Apr 13, 2021
@frascuchon frascuchon mentioned this pull request Apr 13, 2021
@lstarin
Copy link

lstarin commented May 19, 2021

Hello, I'm trying to use spacy-wordnet with spacy 3, but I have some problems. I cannot run the example as it is here, I get the error that using spacy.load("en") is deprecated in spacy 3. Then I use this: spacy.load("en_core_web_sm")
But I get this error: ValueError: [E002] Can't find factory for 'spacy_wordnet' for language English (en).
Can you tell me how I can solve this problem?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants