Fix broken Hugging Face link #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thenameless7741
changed the title
ZachNagengast
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Awesome @thenameless7741 thanks for PR #1 🎉
This looks like a great fix, just recommended a check in case the user is in an HF org (it shows up as a second line)
Could also be reduced to just
HF_USERNAME=$(huggingface-cli whoami | head -n 1) \
What do you think?
ZachNagengast
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original link to the models on Hugging Face website was broken, so this PR just fixes it.
Edit 1: I didn't have
git-lfsinstalled when I randownload-models, and I encountered an error while checking out the model repo. So, I added an extra note about that.Edit 2: despite having
$HF_TOKENset and being logged into Hugging Face (verified bymake setup), I couldn't successfully rundownload-modelsdue to an auth error. So I fixed the Makefile to include HF's username and token when cloning the model's repository (I'm not familiar withhuggingface-cli, so I'm not sure how to properly fix this). Side note: users who have set an SSH key on the HF website shouldn't run into this auth issue.ps. Thank you for open sourcing this project!