-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MLX model support #124
Draft
ZachNagengast
wants to merge
10
commits into
main
Choose a base branch
from
mlx-support
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
MLX model support #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added MLX feature extractor implementation * CI fix * added better multiarray conversion * CI fix * CI fix * fixed `asMLMultiArray` implementation, fixed CI * update xcode, trigger pr when targeting not main branch * check if vision os builds * update watch os version * conditional watchos compilation * conditional package.swift * conditional package.swift * ci fix * ci fix * ci fix * ci fix * ci fix * ci fix * ci fix * ci fix * ci fix * ci fix * ci fix * add other tests targest back * package.swift cleanup * general cleanup * revert to xcode 15.2
…into mlx-support
* added mlx audio encoder * fixed model protocols * removed not needed
@jkrukowski relevant: https://ml-explore.github.io/mlx/build/html/install.html#binary-size-minimization We'll want to minimize the binary size as much as reasonable for iOS deployment |
…into mlx-support
* fixes for mlx models * fixed asMLXArray * fixed tests, mlx doesn't run on simulators * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for the early stages of supporting MLX based whisper models directly in WhisperKit. (To be updated)
Initial TODOs:
FeatureExtracting
protocolAudioEncoding
protocolTextDecoding
protocol orTextDecoder
subclass (research needed)Compiling whisperkit-cli optionally with/without MLXCrossing this out for now: whisperkit-cli does not have the same bundle size constraints as the core libraryxcodebuild
instead of iOS simulator (simulator is not supported for MLX)