Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ArgminRandom impl for primitive types and added tests #280

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

stefan-k
Copy link
Member

No description provided.

@stefan-k stefan-k self-assigned this Dec 16, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 91.70% // Head: 91.72% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (bceaf3c) compared to base (89a638b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
+ Coverage   91.70%   91.72%   +0.02%     
==========================================
  Files         118      119       +1     
  Lines       17716    17742      +26     
==========================================
+ Hits        16246    16274      +28     
+ Misses       1470     1468       -2     
Impacted Files Coverage Δ
argmin-math/src/nalgebra_m/random.rs 96.42% <100.00%> (+0.13%) ⬆️
argmin-math/src/ndarray_m/random.rs 100.00% <100.00%> (+3.27%) ⬆️
argmin-math/src/primitives/random.rs 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefan-k stefan-k merged commit 2a0de83 into argmin-rs:main Dec 16, 2022
@stefan-k stefan-k deleted the fix_argminrandom_primitives branch December 16, 2022 18:23
@stefan-k stefan-k mentioned this pull request Dec 16, 2022
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants